Skip to content

refactor: support get_child_blocks along with get_child_descriptors - #231

Merged
ormsbee merged 1 commit into
openedx:masterfrom
open-craft:agrendalath/rename_descriptor_to_block
Apr 26, 2023
Merged

refactor: support get_child_blocks along with get_child_descriptors#231
ormsbee merged 1 commit into
openedx:masterfrom
open-craft:agrendalath/rename_descriptor_to_block

Conversation

@Agrendalath

@Agrendalath Agrendalath commented Apr 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Description: This method will be renamed in the Redwood release.

Dependencies: This is required to support changes from openedx/openedx-platform#31492.

Testing instructions: See that the tests from openedx/openedx-platform#31492 are passing.

Reviewers:

  • tag reviewer

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings): n/a
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPi after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

@openedx-webhooks

openedx-webhooks commented Apr 25, 2023

Copy link
Copy Markdown

Thanks for the pull request, @Agrendalath! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 25, 2023
@Agrendalath
Agrendalath force-pushed the agrendalath/rename_descriptor_to_block branch from bd71b17 to f4be432 Compare April 25, 2023 16:49
@Agrendalath Agrendalath mentioned this pull request Apr 25, 2023
Merged
@Agrendalath
refactor: support get_child_blocks along with get_child_descriptors
8141967 
This method will be renamed in the Redwood release.
@Agrendalath
Agrendalath force-pushed the agrendalath/rename_descriptor_to_block branch from f4be432 to 8141967 Compare April 26, 2023 13:18
@ormsbee
ormsbee merged commit 4f2e83b into openedx:master Apr 26, 2023
@openedx-webhooks

openedx-webhooks commented Apr 26, 2023

Copy link
Copy Markdown

@Agrendalath 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@Agrendalath
Agrendalath deleted the agrendalath/rename_descriptor_to_block branch April 26, 2023 13:44
@Agrendalath

Agrendalath commented Apr 26, 2023

Copy link
Copy Markdown
Member Author

@ormsbee, would you mind creating a release to push the new version to PyPI?

@ormsbee

ormsbee commented Apr 26, 2023

Copy link
Copy Markdown

@Agrendalath: Done (thanks to @kdmccormick, who clued me in to how we're using GitHub release now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ormsbee ormsbee ormsbee approved these changes

Assignees

No one assigned

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Agrendalath @openedx-webhooks @ormsbee